Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1549/b53f7d72 backport][stable-6] s3_object - fix regression related to leading / in object key names #1554

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 16, 2023

This is a backport of PR #1549 as merged into main (b53f7d7).

SUMMARY

fixes #1548

S3 object key names should not include a leading / (https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html). However, for historical reasons we've supported them (we just pruned them out) this pruning was dropped in 6.0.0 without warning.

For the sake of simplifying things and moving closer to the actual AWS resources, deprecate pruning out the leading /. (Arbitrarily modifying inputs and resource names tends to lead to strange edge cases)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_object

ADDITIONAL INFORMATION

Regression of ansible/ansible#30576 / ansible/ansible#30579

…1549)

s3_object - fix regression related to leading / in object key names

SUMMARY
fixes #1548
S3 object key names should not include a leading / (https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html).  However, for historical reasons we've supported them (we just pruned them out) this pruning was dropped in 6.0.0 without warning.
For the sake of simplifying things and moving closer to the actual AWS resources, deprecate pruning out the leading /.  (Arbitrarily modifying inputs and resource names tends to lead to strange edge cases)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Regression of ansible/ansible#30576 / ansible/ansible#30579

Reviewed-by: Alina Buzachis
(cherry picked from commit b53f7d7)
@github-actions
Copy link

github-actions bot commented May 16, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9868af0f0387437c8ddc52ec84c7793d

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 12m 32s
✔️ ansible-test-splitter SUCCESS in 4m 40s
✔️ integration-amazon.aws-1 SUCCESS in 10m 48s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 17, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0cfadfe9b25943c3a4c88385806415ca

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 13m 24s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-amazon.aws-1 SUCCESS in 12m 25s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4e4e1df into stable-6 May 17, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/b53f7d727509cc36de45d98ad0dd403a001d7a73/pr-1549 branch May 17, 2023 12:22
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant